I think initis too early in the WordPress loading steps.

Does it works at template_redirect?
https://developer.wordpress.org/reference/functions/wp_redirect/#comment-2752

Both init and wp_loaded are indeed too early, because if you add something like this:

add_action('init', function () {
    echo '<pre>init:'.print_r(get_post(),true).'</pre>';
});

add_action('wp_loaded', function () {
    echo '<pre>wp_loaded:'.print_r(get_post(),true).'</pre>';
});

You’ll see that it prints both hook names, but no post, which is something your hook relies on.

According to the docs, template_redirect is the right approach:

This action hook executes just before WordPress determines which template page to load. It is a good hook to use if you need to do a redirect with full knowledge of the content that has been queried.

https://developer.wordpress.org/reference/hooks/template_redirect/

If I add something like this to a plugin (and only this), and I visit the homepage, it redirects as expected:

add_action('template_redirect', function () {
    if (!is_home()) return;
    wp_safe_redirect('/test');
    exit;
});

The most common case I’ve seen for your error is that there may be PHP errors or warning output somewhere before your redirect. Do you have WP_DEBUG and WP_DEBUG_LOG set to true in wp-config.php, and perhaps also WP_DEBUG_DISPLAY set to false:

define( 'WP_DEBUG', true );
define( 'WP_DEBUG_LOG', true );
define( 'WP_DEBUG_DISPLAY', false );

Then check debug.log in wp-content to see if there are any warnings or errors after trying your code.

The other thing I can think of is related to what you said above:

As i said, i’m doing this in a plugin instantiated by a shortcode on a page and i’ve initially created it as an object-oriented class and in the class constructor, i’ve got the following code:

Are you possibly trying to add the template_redirect action within the shortcode logic (nesting your hooks)? If so, that might already be too late for the hook to fire, because you’re already rendering a template.

From a WordPress perspective, it doesn’t matter where in the class you put it, as long as you’re not adding a hook within another hook.

At the end of the day, when your class gets instantiated, most of the time you’re just adding all of the hooks, which get fired where WordPress calls them.

Whether you put them all in the constructor or in other methods, just depends on the complexity and size of the class, and how you want to organize/read it.

From that architecture perspective, I set up my plugins as follows:

• test-plugin
• — plugin
• —- Plugin.php
• — autoloader.php
• — test-plugin.php

That’s the basis. And then each file kind of looks like this:

test-plugin.php

<?php

namespace RYSE\TestPlugin;

// All your plugin header fields here

if (!defined('ABSPATH')) exit;

require_once 'autoloader.php';

new Plugin(__FILE__);

autoloader.php

<?php

namespace RYSE\TestPlugin;

/**
 * Require plugin classes on demand.
 *
 * @author Ryan Sechrest
 * @package RYSE\TestPlugin
 */
spl_autoload_register(function ($class) {

    // Remove organization and plugin name from namespace:
    // <organizationName>\<pluginName>\Foo\Bar => Foo\Bar
    $class = substr($class, strlen(__NAMESPACE__ . '\\'));

    // Convert namespace to path:
    // Foo\Bar => Foo/Bar
    $class = str_replace('\\', DIRECTORY_SEPARATOR, $class);

    // Append PHP file extension:
    // Foo/Bar => Foo/Bar.php
    $class = $class . '.php';

    // Prepend plugin directory:
    // Foo/Bar.php => plugin/Foo/Bar.php
    $class = 'plugin/' . $class;

    // Prepend current directory:
    // plugin/Foo/Bar.php => .../wp-content/plugins/<pluginName>/plugin/Foo/Bar.php
    $class = dirname(__FILE__) . '/' . $class;

    // If file does not exist, exit
    if (!file_exists($class)) return;

    // Require class: .../wp-content/plugins/<pluginName>/plugin/Foo/Bar.php
    require_once $class;
});

Plugin.php

<?php

namespace RYSE\TestPlugin;

/**
 * Starting point for plugin.
 *
 * @author Ryan Sechrest
 * @package RYSE\TestPlugin
 */
class Plugin extends BasePlugin
{
    /**
     * Absolute path to plugin file.
     *
     * @var string .../wp-content/plugins/<pluginDir>/<pluginName>.php
     */
    private string $file = '';

    /***********************************************************/

    /**
     * Register plugin hooks.
     *
     * @param string $file ..../wp-content/plugins/<pluginDir>/<pluginName>.php
     */
    public function __construct(string $file)
    {
        $this->file = $file;

        $this->registerActivationHook();
        $this->registerDeactivationHook();
        $this->registerUninstallHook();

        $this->load();
    }

    /**
     * Load core plugin functionality.
     */
    private function load(): void
    {
        $this->addAdminNotice();
    }

    /***********************************************************/

    /**
     * Add admin notice.
     *
     * @return void
     */
    private function addAdminNotice(): void
    {
        add_action('admin_notices', [$this, '_addAdminNotice']);
    }

    /**
     * Hook to add admin notice.
     *
     * @return void
     */
    public function _addAdminNotice(): void
    {
        echo '<div class="notice notice-info">';
        echo '<p>Hi, I'm a notice.</p>';
        echo '</div>';
    }

    /***********************************************************/

    /**
     * Register plugin activation hook.
     *
     * @return void
     */
    private function registerActivationHook(): void
    {
        register_activation_hook($this->file, [$this, 'activate']);
    }

    /**
     * Run when plugin is activated.
     *
     * @return void
     */
    public static function activate(): void
    {
        // No actions to perform.
    }

    /*---------------------------------------------------------*/

    /**
     * Register plugin deactivation hook.
     *
     * @return void
     */
    private function registerDeactivationHook(): void
    {
        register_activation_hook($this->file, [$this, 'deactivate']);
    }

    /**
     * Run when plugin is deactivated.
     *
     * @return void
     */
    public static function deactivate(): void
    {
        // No actions to perform.
    }

    /*---------------------------------------------------------*/

    /**
     * Register plugin uninstall hook.
     *
     * @return void
     */
    private function registerUninstallHook(): void
    {
        register_uninstall_hook(
            $this->file,
            ['RYSE\TestPlugin\Plugin', 'uninstall']
        );
    }

    /**
     * Run when plugin is deleted (via the UI).
     *
     * @return void
     */
    public static function uninstall(): void
    {
        // No actions to perform.
    }
}

This is untested. I modified the above to keep it simple and focused on structure, but hopefully this gives you an idea. Then, as the plugin grows, I’ll add more classes in plugin, and instead of adding the hooks directly in Plugin.php, I’ll just instantiate other classes that will add those hooks.

I should also note that this isn’t the ‘WordPress way’, but it’s my way, haha. It’s a model that has worked for me.

• This reply was modified 1 month ago by Ryan Sechrest. Reason: Fix bullet points. Didn't render indented as in preview