Use the right user ID to accept/reject group invites #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless an Administrator is viewing another member's group invitations screen, the right user ID to use is the logged in user ID.
|
Your fix looks good to me! I agree that it should nearly always be the logged-in user's ID, with the very unusual exception that an admin is helping another user accept an invite, which you've covered. |
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Jun 2, 2024
The displayed user ID should only be used when an administrator is viewing a user profile. In all other contexts, the logged in user ID needs to be used. This change is fixing the issue when accepting such an invite from the groups directory. Props kainelabsteam, dcavins Fixes #9135 Closes buddypress/buddypress#285 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13862 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless an Administrator is viewing another member's group invitations screen, the right user ID to use is the logged in user ID.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9135
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.