Apply 9111.patch but use SCSS to generate styles #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parts of BuddyPress (like this one) are using SCSS, so we need to edit the corresponding SCSS file otherwise when running `grunt commit` or `grunt style` or `grunt build` the `.css` edits are removed.
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
May 6, 2024
This screen targets Community Site Admins to inform them about the top features included in a new version of the plugin, its full change log as well as to explain how they can get involved into the BuddyPress open source project. About this last point, the "Get Involved" subpage layout has also been improved so that warnings about how we can contribute to BuddyPress docs are better displayed. Props emaralive See #9111 (trunk) Closes buddypress/buddypress#263 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13789 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of BuddyPress (like this one) are using SCSS, so we need to edit the corresponding SCSS file otherwise when running
grunt commitorgrunt styleorgrunt buildthe.cssedits are removed.PS: sorry @emaralive I forgot to mention it in my previous comment on the ticket. Otherwise, I've tested the patch and I confirm it behaves as expected 👍. Great job.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9111
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.