Directory

Only parse `heartbeat` requests which relates to BuddyPress context by imath · Pull Request #247 · buddypress/buddypress · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only parse heartbeat requests which relates to BuddyPress context #247

Closed
wants to merge 1 commit into from

Conversation

imath
Copy link
Member

@imath imath commented Mar 2, 2024

The Query Monitor plugin is showing some notice errors about the way some specific Ajax requests were handled by the BP Rewrites API. This PR aims to remove these notices making sure the heartbeat action is about a BuddyPress context.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9099


This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.

Copy link
Member

@renatonascalves renatonascalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@imath imath deleted the patch/9099 branch March 8, 2024 01:35
dcavins pushed a commit to dcavins/buddypress-wp-svn that referenced this pull request May 6, 2024
Props Slaffik, needle, espellcaste

See #9099 (trunk)
Closes buddypress/buddypress#247



git-svn-id: http://buddypress.svn.wordpress.org/trunk@13752 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants