Directory

Verification of backup codes could be stronger · Issue #56 · WordPress/wporg-two-factor · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of backup codes could be stronger #56

Open
kraftbj opened this issue Feb 9, 2023 · 4 comments
Open

Verification of backup codes could be stronger #56

kraftbj opened this issue Feb 9, 2023 · 4 comments
Milestone

Comments

@kraftbj
Copy link

kraftbj commented Feb 9, 2023

With the current flow, is there a way that the last “backup codes” box is not checked while having 2fa active?

Seeing that before I started 2fa, I figured it would be something I’ve seen elsewhere that asks for a backup code for verification-of-saving on the next screen after the backup codes were displayed.

2023-02-09 at 7 03 AM

By doing that, we actually do verify that someone did something to retain their backup codes instead of clicking through (out of ignorance, accident, etc).

@iandunn iandunn added this to the Iteration 1 milestone Feb 9, 2023
@iandunn
Copy link
Member

iandunn commented Feb 9, 2023

Are you saying that the Backup Codes status box in your screenshot should be hidden until TOTP is setup? So that when a new user visits the page, it'd look like this?

Screenshot 2023-02-09 at 2 25 08 PM

...or just that the box should be disabled / not clickable?

Once they're on that screen, requiring them to check the box before the codes get saved isn't currently possible because of WordPress/two-factor#507, but I'd like to implement that once the upstream issue is resolved.

Related:

@kraftbj
Copy link
Author

kraftbj commented Feb 9, 2023

I mean more on this screen:
2023-02-09 at 5 29 PM
checking the box takes me here:
2023-02-09 at 5 30 PM

I don't think simply checking the box is sufficient to confirm the access the codes.

For example, on WordPress.com, we have a next screen that asks for one of the 10 codes generated to confirm that the person copied/printed them.
2023-02-09 at 5 32 PM

@iandunn
Copy link
Member

iandunn commented Feb 9, 2023

Ah, I see! Yeah, I think that's a good idea 👍🏻

@dd32
Copy link
Member

dd32 commented Feb 10, 2023

Part of this is caused by / limited by WordPress/two-factor#507 - The backup codes are already saved and in-use before the checkbox on that UI is selected; they're saved at generation time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants