Directory

Size of the dots in hero section to match to other dots in sub-footer section · Issue #189 · WordPress/wporg-showcase-2022 · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of the dots in hero section to match to other dots in sub-footer section #189

Closed
marko-srb opened this issue Sep 27, 2023 · 3 comments
Assignees
Labels
[Component] Theme Templates, patterns, CSS

Comments

@marko-srb
Copy link

Is there a way we can pull off this with pure CSS instead of an image? Know there have been discussions before, but to see if that's doable...

Can we make these dots:
Screen Shot 2023-09-27 at 22 40 08

Seem same size as these dots:
Screen Shot 2023-09-27 at 22 40 15

@ryelle
Copy link
Contributor

ryelle commented Sep 27, 2023

Is there a way we can pull off this with pure CSS instead of an image? Know there have been discussions before, but to see if that's doable...

Not really — not without having the corners misaligned or dots getting cut off (I tried). I really don't want to go down the path of changing the implementation for this again when we finally got it working. but I'm happy to change out that SVG for a new one if you want to update it.

Here's what it would look like if I just change the size of the dots, but I don't know if you'd also want to update the spacing between dots.

Screen Shot 2023-09-27 at 16 48 52

@ryelle ryelle added [Status] Needs Design Feedback Feedback is needed on an existing or new component [Component] Theme Templates, patterns, CSS labels Sep 27, 2023
@marko-srb
Copy link
Author

@ryelle

Thanks. If you can put this version live, that's good, as long as previous fallback is somewhere to be found? So we can revert easily.

This works well for what we need, but in case someone wants it reverted, we need the current version saved, or guide on how to put it back. Let me know if I can help with that record/tracking somehow.

Thank you!

@ryelle ryelle removed the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Sep 28, 2023
@ryelle ryelle self-assigned this Sep 28, 2023
@ryelle ryelle closed this as completed in d6963b0 Sep 28, 2023
@ryelle
Copy link
Contributor

ryelle commented Sep 28, 2023

If this needs to be undone, the commit can be reverted or just the dots-hero.svg file can be updated to set the r="2.5" back to r="4" — all I did was a find & replace to update this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Archived in project
Development

No branches or pull requests

2 participants