Directory

Fix like icon button not working in some environments by SantosGuillamot · Pull Request #60 · WordPress/wp-movies-demo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix like icon button not working in some environments #60

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

SantosGuillamot
Copy link
Collaborator

@SantosGuillamot SantosGuillamot commented Nov 29, 2023

I've been testing the plugin with the latest changes made in Gutenberg and it seems that after merging the new Store API, the demo is broken. If I am not mistaken, it is because we are still relying on it for the server side rendering, and that part has changed.

EDITED: It seems this should be solved by updating the script ID of the block interactivity experiments plugin to use #wp-interactivity-initial-state instead of #wp-interactivity-store-data: link.

I'm reverting the changes and keep this pull request only with the CSS fix. Which is adding more specificity to the SVG to ensure it is not overwritten by the path.

@SantosGuillamot SantosGuillamot changed the title Prepare demo for upcoming Gutenberg Prepare demo for upcoming Gutenberg release Nov 29, 2023
@SantosGuillamot SantosGuillamot changed the title Prepare demo for upcoming Gutenberg release Fix like icon button not working in some environments Nov 29, 2023
Copy link
Collaborator

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbravobernal cbravobernal merged commit 0a8dfa9 into main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants