Directory

Support forums redesign: Icons in table header not aligned · Issue #239 · WordPress/wordpress.org · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support forums redesign: Icons in table header not aligned #239

Closed
dionysous opened this issue Apr 10, 2024 · 2 comments
Closed

Support forums redesign: Icons in table header not aligned #239

dionysous opened this issue Apr 10, 2024 · 2 comments
Labels
[Site] Forums

Comments

@dionysous
Copy link

Hi @ndiego , I think the redesign is great. However, I have noticed that the icons in the table headers are not centered in relation to the underlying content. I have a suggestion how to solve this within the CSS.

icon-alignmenrt1

icon-alignmenrt2

Solution:

  1. Change this from

    wordpress.org/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css

    Line 3173 in ca74bd1

    .bbpress .forum-titles .bbp-topic-voice-count, 
.bbpress .forum-titles .bbp-topic-reply-count {
	overflow: hidden;
}

to this

.bbpress .forum-titles .bbp-topic-reply-count {
	font-size: 0;
	color: transparent;
}

  1. Replace this line margin-right: 100px;

    wordpress.org/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css

    Line 3180 in ca74bd1

    margin-right: 100px;
    with this
    color: var(--wp--preset--color--charcoal-1);

  2. Remove this margin-left: 20px;

    wordpress.org/wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css

    Line 3188 in ca74bd1

    margin-left: 20px;

@ndiego
Copy link
Member

ndiego commented Apr 10, 2024

Thanks for logging this @dionysous! Looks like @adamwoodnz is on it.

@adamwoodnz
Copy link

Thanks for raising! The design actually replaces the icons with text, and we have an issue for that.

@adamwoodnz adamwoodnz closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Site] Forums
Projects
WordPress.org Redesign
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamwoodnz @ndiego @dionysous