Directory

wpCLI step in the example doesn't match with the heading · Issue #1375 · WordPress/wordpress-playground · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpCLI step in the example doesn't match with the heading #1375

Closed
juanmaguitar opened this issue May 9, 2024 · 0 comments · Fixed by #1377
Closed

wpCLI step in the example doesn't match with the heading #1375

juanmaguitar opened this issue May 9, 2024 · 0 comments · Fixed by #1377

Comments

@juanmaguitar
Copy link
Contributor

The step wpCLI example doesn't match the step stated in the heading.

The example of wpCLI is:

{
    "steps": [
        {
            "step": "wp-cli",
            "command": "wp post create --post_title='Test post' --post_excerpt='Some content'"
        }
    ]
}

Should the heading of this step be changed to wp-cli?
adamziel added a commit that referenced this issue May 9, 2024
@adamziel
Docs: Use step JSON identifier instead of TypeScript function names
30c26e9 
Changing the headings for each step at
https://wordpress.github.io/wordpress-playground/blueprints-api/steps to
correspond with the real value of the step property in the blueprint

The `ActivatePluginStep` heading becomes `activatePlugin`, `CpStep`
becomes `cp` and so on.

Closes #1375
Closes #1374

cc @juanmaguitar
@adamziel adamziel mentioned this issue May 9, 2024
Merged
adamziel added a commit that referenced this issue May 9, 2024
@adamziel
Use step id name (#1377)
756774c 
Changing the headings for each step at
https://wordpress.github.io/wordpress-playground/blueprints-api/steps to
correspond with the real value of the step property in the blueprint

The `ActivatePluginStep` heading becomes `activatePlugin`, `CpStep`
becomes `cp` and so on.

Closes #1375
Closes #1374

cc @juanmaguitar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use step id name WordPress/wordpress-playground
1 participant
@juanmaguitar