Directory

Add unit tests for wp_check_browser_version function by pbearne · Pull Request #6310 · WordPress/wordpress-develop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for wp_check_browser_version function #6310

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

pbearne
Copy link

@pbearne pbearne commented Mar 22, 2024

New unit tests have been implemented for the 'wp_check_browser_version' function in WordPress. This is done to verify the correctness of its output across different user agent strings, including when there's no agent and cases for Chrome on Windows and Android.

Trac ticket: 60828

New unit tests have been implemented for the 'wp_check_browser_version' function in WordPress. This is done to verify the correctness of its output across different user agent strings, including when there's no agent and cases for Chrome on Windows and Android.
Copy link

github-actions bot commented Mar 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

class Tests_dashboard_wp_check_browser_version extends WP_UnitTestCase {

public function set_up() {
/** Load WordPress dashboard API */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Load WordPress dashboard API */
/* Load WordPress dashboard API */

New unit tests have been implemented for the 'wp_check_browser_version' function in WordPress. This is done to verify the correctness of its output across different user agent strings, including when there's no agent and cases for Chrome on Windows and Android.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants