Fix PHP fatal in rest_filter_response_fields when dealing with scalar values #6158
Conversation
`rest_filter_response_fields()` does not currently work if a given API endpoint returns an scalar value.
Adds an `is_array()` check to make sure we are dealing with array based collections.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com>
| @@ -898,7 +898,7 @@ function rest_filter_response_fields( $response, $server, $request ) { | |||
|
|
|||
| $fields = wp_parse_list( $request['_fields'] ); | |||
|
|
|||
| if ( 0 === count( $fields ) ) { | |||
| if ( 0 === count( $fields ) || is_scalar( $data ) ) { | |||
There was a problem hiding this comment.
Is scalar desired or valid? If no, thinking it should also trigger an notice (doing it wrong or wp_trigger_error()) to alert the devs. (instead of silently returning the response)
There was a problem hiding this comment.
A scalar is a valid return type from a REST API controller, so I don't think we need to warn on it.
There was a problem hiding this comment.
Aha good to know. Then yes, I agree, no need to warn.
rest_filter_response_fields()does not currently work if a given API endpoint returns an scalar value.Trac ticket: https://core.trac.wordpress.org/ticket/60599
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.