Prevent redirect loops #6017
Prevent redirect loops #6017
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kkmuffme
force-pushed
the
prevent-redirect-loops
branch
from
770d4fc
to
0d75bac
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
swissspidy
changed the title
kkmuffme
force-pushed
the
prevent-redirect-loops
branch
6 times, most recently
from
7b2c0fe
to
f010802
Compare
kkmuffme
force-pushed
the
prevent-redirect-loops
branch
from
f010802
to
e8041ff
Compare
| } | ||
|
|
||
| return $location; | ||
| } | ||
| endif; | ||
|
|
||
| if ( ! function_exists( '_wp_is_self_redirect' ) ) : |
There was a problem hiding this comment.
Why does this function need to be pluggable?
There was a problem hiding this comment.
'cause we're in pluggable.php :-) If you prefer it non-pluggable, that's fine for me, just let me know.
| * @param bool $expected true if it should redirect | ||
| * @param bool $safe_expected optional expected value of safe_redirect | ||
| */ | ||
| public function test_wp_redirect_loop( $location, $ssl, $host, $request_uri, $expected, $safe_expected = null ) { |
There was a problem hiding this comment.
Rather than doing a lot of heavy lifting here, would e2e tests in playwright make more sense?
There was a problem hiding this comment.
Possibly, but I don't have experience with playwright (use something else at work) and don't have time to learn that atm.
If there's somebody who can create those, great! Otherwise I don't think that's a blocker, since it has proper tests
Prevent redirect loops when trying to redirect to the current URL, except when changing http to https
It's not possible to create tests for this, since phpunit runs in CLI and PHP will always return null for
filter_inputin CLITrac ticket: https://core.trac.wordpress.org/ticket/60208