Directory

Replaced mentions of web site to website by LiamMcArthur · Pull Request #5639 · WordPress/wordpress-develop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced mentions of web site to website #5639

Closed

Conversation

LiamMcArthur
Copy link

Updated mentions of web site to website since the singular version does seem to be used more often throughout WordPress.

Trac ticket: https://core.trac.wordpress.org/ticket/59853#ticket


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

@ironprogrammer ironprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, @LiamMcArthur 👍🏻 One minor tweak suggested:

src/wp-includes/SimplePie/Sanitize.php Outdated Show resolved Hide resolved
Copy link

@ironprogrammer ironprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Thanks, @LiamMcArthur!

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r57131.

@LiamMcArthur LiamMcArthur deleted the hotfix/website-wording branch November 22, 2023 18:58
@LiamMcArthur
Copy link
Author

@ironprogrammer @SergeyBiryukov I noticed these changes were reverted https://core.trac.wordpress.org/changeset/57113 - does anyone know what the reason for this was?

@ironprogrammer
Copy link

Hi, @LiamMcArthur -- Looking into this, on 2023-11-15 r57112 mistakenly included the updates from this PR alongside another patch, which were indeed reverted in r57113.

However, the subsequent merge on 2023-11-22 of r57131 occurred later, and from what I see today in wordpress-develop:trunk, retains these updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants