Directory

Docs: update submit_button function docs to match implementation by benjaminknox · Pull Request #5605 · WordPress/wordpress-develop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update submit_button function docs to match implementation #5605

Conversation

benjaminknox
Copy link

@benjaminknox benjaminknox commented Nov 1, 2023

Updates the docs on submit_button and get_submit_button function to match the general implementation used in wordpress. In https://core.trac.wordpress.org/changeset/21311 the usage of tabindex="1" was removed and it was suggested that another example be used. This PR switches the docs to use the id attribute as an example instead.

Trac ticket: https://core.trac.wordpress.org/ticket/59768


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r57114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants