Changes to TT4 for RC2 #5552
Changes to TT4 for RC2 #5552
Conversation
| @@ -18,7 +18,6 @@ | |||
| * | |||
| * @return void | |||
| * @since Twenty Twenty-Four 1.0 | |||
There was a problem hiding this comment.
nit: Just noticing this now, but @SInCE should be before @return here and in the other spots. See: https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#1-functions-class-methods
There was a problem hiding this comment.
I'll make these changes precommit and submit back to WordPress/twentytwentyfour.
There was a problem hiding this comment.
Ah, never mind. I see that WordPress/twentytwentyfour#693 been opened. Approved and merged.
There was a problem hiding this comment.
@return void
should also be removed. Will open an issue to fix in the TT4 repo.
There was a problem hiding this comment.
@hellofromtonya According to https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#1-functions-class-methods Note: @return void should not be used outside of the default bundled themes.
|
@Yari2u @KalmanG @aayushastha I was unable to locate your WordPress.org profile. A WordPress.org profile is required to receive proper credit for contributions on the About screen within the WordPress dashboard for a given release. Could you please share your .org profile if you already have one that I missed, or follow the instructions in this blog post to create and connect a .org account. |
|
@desrosj We have them listed in our CONTRIBUTORS.md file with both Github and w.org profiles: https://github.com/WordPress/twentytwentyfour/blob/trunk/CONTRIBUTORS.md
|
This PR includes the bugfixes from the GH repo since RC 1.
Some patterns have been updated to fix color issues, a well as some code quality fixes.
/cc @MaggieCabrera
Trac ticket: https://core.trac.wordpress.org/ticket/59711
Props:
@richtabor
@MaggieCabrera
@luminuu
@kafleg
@swissspidy
@huzaifaalmesbah
@neilorangepeel
@shail-mehta
@aayushastha
@lada7042
@KalmanG
@mukeshpanchal27
@nilovelez
@Yari2u
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.