-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update polyfill-library, wp-polyfill-node-contains and wp-polyfill-node-contains #5215
Update polyfill-library, wp-polyfill-node-contains and wp-polyfill-node-contains #5215
Conversation
…6.0 to 4.7.0 and wp-polyfill-dom-rect 4.6.0 to 4.7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you also need to run npm install
in order to update the package-lock.json
file.
src/wp-includes/script-loader.php
Outdated
@@ -113,9 +113,9 @@ function wp_default_packages_vendor( $scripts ) { | |||
'lodash' => '4.17.19', | |||
'wp-polyfill-fetch' => '3.6.17', | |||
'wp-polyfill-formdata' => '4.0.10', | |||
'wp-polyfill-node-contains' => '4.6.0', | |||
'wp-polyfill-node-contains' => '4.7.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated to match the package version, 4.8.0
. Seems this was missed on the last update.a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@desrosj "wp-polyfill-node-contains" updated to 4.8.0 and run npm install
command.
Thanks @mdhrshahin20! There was one small change I just made. Looks ready to commit. |
This was merged in https://core.trac.wordpress.org/changeset/56646. |
Thank you @desrosj . |
Trac ticket: https://core.trac.wordpress.org/ticket/59077
Description:
Update polyfill-library 4.7.0 to 4.8.0 , wp-polyfill-node-contains 4.6.0 to 4.7.0 and wp-polyfill-dom-rect 4.6.0 to 4.7.0
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.