Load theme-preview.php after pluggable functions get defined
#5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okmttdhr
changed the title
theme-preview.php after pluggable functions get defined
|
Hello, @SergeyBiryukov @johnbillion! Both failing tests (E2E, performance) are passing on my local, at least. |
|
This makes perfect sense to me, thanks for working on it. |
|
Hello, @azaozz @mtias @noisysocks! |
I'm closing this PR in favor of a new one: #5107. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes WordPress/gutenberg#53284. #4959 tried to fix the same issue, but there is a concern about its reliability, depending on timing.
Hence, this PR changed to load
theme-previews.php, which is the cause of this issue, after the pluggable functions. The reason for this is that running capability checks before defining pluggable functions itself does not seem to be a good approach.Fixes WordPress/gutenberg#53284
Trac ticket: https://core.trac.wordpress.org/ticket/59000
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.