Include attachments and featured images for posts being exported #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, attachmets are only exported if you choose to export with the 'all' option. This change will get the attachment IDs of all of the posts being exported when the 'all' option isn't used.
This commit refactors the Test_Export_Includes_Attachments test class to use protected static properties for the post and attachment variables. It also introduces a second test post with a different author and an attached file. The test method has been updated to check for post IDs instead of post titles to make the assertions more robust. Additionally, the test now ensures that the export function only includes posts and attachments for the specified author, and it verifies this by asserting the count of items in the exported XML. These changes improve the test coverage and make the test more reliable.
|
If support for PHP versions < v7 has been dropped, why is a unit test for 5.6 holding up the merge of a patch for a 12 year old Trac ticket? |
|
@electricbrick Should I close this pull request and open a new one? That would trigger a new checks on the code that don't include PHP 5.6. |
|
@nate-allen Good question... By the way, my reply was meant more for maintainers to see activity on the ticket, and not shade @ you. is a new PR against the rules? Because maybe it would work — are there potentially unforeseen consequences though? An alternative is someone could show up at the Make Slack contributors stand-up and advocate for it. I don't know if that's still held on Wednesdays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where attachments are not included when exporting posts, unless you choose the "all" option.
A unit test is also included.
Trac ticket: 17379
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.