Directory

Fix: Rename variables in post.php to maintain coding standards by tanjimTC · Pull Request #4061 · WordPress/wordpress-develop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename variables in post.php to maintain coding standards #4061

Closed
wants to merge 2 commits into from
Closed

Fix: Rename variables in post.php to maintain coding standards #4061

wants to merge 2 commits into from

Conversation

tanjimTC
Copy link

Fixes #57692

This pull request renames the variables $post_IDs and $post_ID in the "wp-admin/includes/post.php" file to align with the WordPress coding standards.

  • $post_IDs is renamed to $post_ids
  • $post_ID is renamed to $post_id_from_data to avoid conflicts and maintain coding standards.

The changes were thoroughly tested and are ready for review. Thank you for considering this pull request.

Trac ticket: https://core.trac.wordpress.org/ticket/57692

@SergeyBiryukov
Copy link
Member

Thanks for the PR!

I think we can just use $post_id here, as it does not appear to conflict with any existing variable. This would also be more consistent with the rest of core, which generally uses $post_id when referring to a post ID.

@SergeyBiryukov
Copy link
Member

Merged in r55365 as part of a few other similar edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants