Directory

added filter for 'header_image()' function by hz-tyfoon · Pull Request #2958 · WordPress/wordpress-develop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added filter for 'header_image()' function #2958

Closed
wants to merge 4 commits into from

Conversation

hz-tyfoon
Copy link

Trac ticket: 56180


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@hz-tyfoon
Copy link
Author

Just updated the PR.
removed the filter from header_image & added a filter in get_header_image.

Looks like it may make more sense to add the filter to get_header_image function as this way it'll work for both header_image & get_header_image (as inside header_image() there's only get_header_image() and then just printing the image url ).

Thanks @SergeyBiryukov for pointing this out.

@hz-tyfoon hz-tyfoon closed this Jul 12, 2022
@hz-tyfoon hz-tyfoon deleted the filter-for-header-image branch September 27, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants