Directory

Move later Heartbeat minimalInterval conversion to microseconds by Tabrisrp · Pull Request #2361 · WordPress/wordpress-develop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move later Heartbeat minimalInterval conversion to microseconds #2361

Closed
wants to merge 1 commit into from
Closed

Move later Heartbeat minimalInterval conversion to microseconds #2361

wants to merge 1 commit into from

Conversation

Tabrisrp
Copy link

Move the minimalInterval valu conversion to microseconds later to avoid setting an incorrect value of mainInterval when mainInterval is inferior to minimalInterval

Trac ticket: https://core.trac.wordpress.org/ticket/54825

audrasjb
audrasjb approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peterwilsoncc
Copy link
Contributor

Committed in https://core.trac.wordpress.org/changeset/53226 with some slight shuffling of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrasjb audrasjb audrasjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Tabrisrp @peterwilsoncc @audrasjb