Latest Site Hint: Don't hint when the year is the same. #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as the current site, that has an identifier.
|
Just noting; I didn't get a chance to add a unit test today, I'll follow up with one next week |
|
Github actions are completely broken due to unrelated changes, and I can't run unit tests locally due to incompatibilities in how this codebase is setup. I can't duplicate the failing unit test outside of the unit tests. |
Fix PHPCS feedback.
|
I tried to fix the tests, but it's going to be stuck between a unit test fail and a static analysis fail atm! |
Fix latest static analysis - forgot this was why!
|
Having trouble testing this PR - both locally and on a sandbox - will continue looking later. |
To avoid php warning
|
Testing the PR works, just can't figure out why the unit tests are failing |
|
Did this another way using a toggle, since there appears to be a few edges cases (probably more too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created an additional site for Canada 2024, such that they can have an English and French site. See https://wordpress.slack.com/archives/C08M59V3P/p1706836174954409
However, this has caused the latest site hint to suggest this:
This change updates the code to strip the
-identifierpart of/2024-fr/from the url for the comparison.How to test the changes in this Pull Request: