-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text correction on wordcamp Incident Report form #1177
Comments
This HTML is generated by the Jetpack Contact form module. The relevant shortcode is this:
It looks like this changed the HTML markup intentionally: Unfortunately, the twentyten theme styles legends differently than labels, and I'm not sure Jetpack should expect otherwise. |
Additionally the above PR added an extra The fix required here is going to be a bunch of CSS styles that override twentytens styles, and/or a jetpack bug report to revert/change the behaviour. |
I did not find a problem with the Jetpack form in my own WordPress installation, so Automattic/jetpack#34147 seems to have fixed the Jetpack plugin. In my test, the group has one fieldset with a visible legend as its first child element, and each option has a visible label programmatically connected to its button. However, the WordCamp site has temporary tweaks from #874 that probably do not belong there anymore. wordcamp.org/public_html/wp-content/mu-plugins/jetpack-tweaks/miscellaneous.php Lines 199 to 206 in 7823c7a
The first item ("Yes") needs to be a label for the radio button, and the screen-reader-only styles for legend elements are not appropriate on the Incident Report page (any other forms likely should not hide the legend either). |
Describe the bug
In the Incident Report form "Yes" text is not visible. (https://central.wordcamp.org/incident-report/).
Steps to reproduce the behavior:
Expected behavior
Screenshots
Solution:
Just need to replace "legend" tag with "label"
The text was updated successfully, but these errors were encountered: