This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Adding sans-serif and serif system fonts #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richtabor I just merged in the latest updates for the style variations, please have a look! |
|
@luminuu I had replaced sandstorm with "Ember" in #649. @beafialho, did you want to add it back? |
richtabor
previously requested changes
Oct 16, 2023
richtabor
force-pushed
the
572-consider-adding-a-systemweb-safe-font-as-an-alternative-to-default-fonts
branch
from
181854c
to
02bd50f
Compare
MaggieCabrera
approved these changes
Oct 16, 2023
This was referenced Oct 16, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds sans-serif and serif system fonts to the typography section. It has to be added to every style variation that changes the typography setup from the main
theme.json.A system font stack is a lightweight alternative to the provided fonts that the theme is designed with.
Alternative to #573, #590, #591.
Screenshots
Testing Instructions
Alternative: