improved mentionsbot v1.0.1 #137
Conversation
- log exception if one happens when notifying users - allow groups to define whether triggering message should be quoted or whether mentions should always be in a thread - move sync config frequency from constant to config
ashfame
force-pushed
the
improved_mentions_bot
branch
from
3fc1377
to
c5047df
Compare
There was a problem hiding this comment.
I think this is fine as is, so I'm approving.
However, I think it might be a bit weird that the plugin behaves differently for different teams. I suspect users will be confused by the fact that sometimes the mention happens in a thread, sometimes not, and that sometimes it quotes the message, sometimes not.
I understand this is the intended behaviour here but, given that the user mentioning the team might not be aware that these things are configurable, they might interpret the difference in behaviour across teams to be a bug.
Personally, I would prefer that the plugin behaves the same always, and I would make it always mention in the thread, since I don't see a use case for having the mention not go in a thread. I would prefer consistency over configurability here.
That said, as mentioned above, I think this is fine as is.
|
People of different teams have their preferences of how it should function. Whether the ping should be in a regular message or threaded was voiced in WordPress/matrix#13 already. Hence, configuration on a group level to give everyone the option they would like :) |
|
I understand the reasoning for implementing that feature as it is here (a user asked for it). But I disagree that that feature should exist, because I don't see a use case for the mention not going into a thread. That's what I was voicing above :) |
|
Folks in community have strong feelings about threads and would often tell people to not use threads on their first attempt to reply in a thread :) |
This PR improves the mentions bot plugin, bumping it to v1.0.1