Directory

Interactivity API: No implicit any by sirreal · Pull Request #61695 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactivity API: No implicit any #61695

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

Interactivity API: No implicit any #61695

wants to merge 5 commits into from

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented May 15, 2024

  • Strict type checking
  • rename to tsx
  • isPlainObject
  • hooks types
  • types
  • types
  • stricter…
  • implicit this
  • strict nulls
  • handle not found text entry
  • hooks
  • store
  • Scope
  • I hate it
  • More strict
  • restart and try again
  • Better
  • Update changelog
  • Fix namespace regression, use named groups
  • Remove redundant group from ns regex
  • Update packages/interactivity/CHANGELOG.md
  • Still learning to type
  • Better variable naming
  • Remove config
  • vdom
  • No implicit any index
  • init
  • I hate it (hooks)

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@sirreal sirreal force-pushed the add/interactivity-no-impl-any branch from a4426a8 to b60d975 Compare May 15, 2024 19:36
@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Packages] Interactivity /packages/interactivity labels Jun 13, 2024
@sirreal sirreal force-pushed the add/interactivity-no-impl-any branch from b60d975 to 195e7e9 Compare June 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisherranz luisherranz Awaiting requested review from luisherranz luisherranz will be requested when the pull request is marked ready for review luisherranz is a code owner

@DAreRodz DAreRodz Awaiting requested review from DAreRodz DAreRodz will be requested when the pull request is marked ready for review DAreRodz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Packages] Interactivity /packages/interactivity [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sirreal @gziolo