Block editor: scroll block into view on insert #61418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
changed the title
|
Size Change: +151 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e20cff2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8994977163
|
scruffian
reviewed
May 7, 2024
| @@ -2751,7 +2751,7 @@ export function wasBlockJustInserted( state, clientId, source ) { | |||
| * @return {boolean} True if the block is visible. | |||
| */ | |||
| export function isBlockVisible( state, clientId ) { | |||
| return state.blockVisibility?.[ clientId ] ?? true; | |||
There was a problem hiding this comment.
This was added in #41104 and was always defaulted to true.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
force-pushed
the
try/zoom-out-scroll-on-insert
branch
from
6b7b3c7
to
8543cfd
Compare
draganescu
previously requested changes
May 8, 2024
youknowriad
reviewed
May 8, 2024
| if ( ! defaultView.IntersectionObserver ) { | ||
| return; | ||
| } | ||
| const observer = new defaultView.IntersectionObserver( |
There was a problem hiding this comment.
Do we really need an intersection observer here? Can't we just scroll into view directly? Or check the position at the moment of the block selection. An observer is something that runs constantly.
There was a problem hiding this comment.
I know this calls disconnect on first observe but still.
There was a problem hiding this comment.
It disconnects immediately, the observer will always immediately call the callback with the initial intersecting state of the element. As for as I know this is the only way to check if an element is visible without using a library.
The Intersection Observer API allows you to configure a callback that is called when either of these circumstances occur:
- A target element intersects either the device's viewport or a specified element. That specified element is called the root element or root for the purposes of the Intersection Observer API.
- The first time the observer is initially asked to watch a target element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When inserting a block (at the bottom, or after the selected block), the inserted block should be scrolled into view.
Why?
You currently don't know if anything has been inserted.
How?
When a block becomes selected, we can check if the block is in view, and if not, scroll it into view.
Testing Instructions
Screenshots or screencast
May-07-2024.12-17-40.mp4