Add list item wrapper to social links when used in navigation block #61396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #61385
Why?
As mentioned in that issue, when the social block is used in the navigation block, the front-end markup has a
<ul>
nested in a<ul>
, when it seems the proper thing to do is have a wrapping<li>
tag.How?
There's an array
$needs_list_item_wrapper
in the server render callback for the navigation block, and adding social links to that seems to do the trick.Testing Instructions
<li>
tagAlso check that none of the styling is broken (this is my greatest concern with the change).
Screenshots or screencast