Directory

Theme JSON: backport PHP annotations from Core by ramonjd · Pull Request #61301 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme JSON: backport PHP annotations from Core #61301

Merged
merged 1 commit into from
May 2, 2024

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented May 2, 2024

What?

Just backporting PHP annotations from Core Theme JSON method for consistency.

See source: https://github.com/ramonjd/wordpress-develop/blob/ebc66bb9a13180d85f5a8b374d85ce14e0b7b2db/src/wp-includes/class-wp-theme-json.php#L2043-L2043

@ramonjd ramonjd added the Backport from WordPress Core Pull request that needs to be backported to the a Gutenberg release from WordPress Core label May 2, 2024
@ramonjd ramonjd self-assigned this May 2, 2024
Copy link

github-actions bot commented May 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd merged commit edb7e4e into trunk May 2, 2024
62 of 63 checks passed
@ramonjd ramonjd deleted the backport/since-annotation-theme-json branch May 2, 2024 02:01
@ramonjd ramonjd added the [Type] Developer Documentation Documentation for developers label May 2, 2024
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Developer Documentation, Backport from WordPress Core.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to the a Gutenberg release from WordPress Core [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant