Directory

Add documentation for PostAuthor, PostAuthorCheck, PostAuthorPanel components by akasunil · Pull Request #61090 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for PostAuthor, PostAuthorCheck, PostAuthorPanel components #61090

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

akasunil
Copy link
Contributor

What?

Part of: #60358

Added documentation in the readme for PostAuthor, PostAuthorCheck, PostAuthorPanel components and also on components itself.

@akasunil akasunil marked this pull request as ready for review April 25, 2024 10:29
Copy link

github-actions bot commented Apr 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Apr 25, 2024
@@ -11,6 +11,15 @@ import PostTypeSupportCheck from '../post-type-support-check';
import { store as editorStore } from '../../store';
import { AUTHORS_QUERY } from './constants';

/**
* Component to render its children only if the post type supports the author.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not native speaker but I think we can improve the wording a bit here. What about

Suggested change
* Component to render its children only if the post type supports the author.
* Wrapper component that renders its children only if the post type supports the author.

@youknowriad youknowriad merged commit 6a0120b into WordPress:trunk Apr 26, 2024
59 of 60 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 26, 2024
@akasunil akasunil deleted the update/documentation-postAuthor branch April 26, 2024 13:26
huubl pushed a commit to huubl/gutenberg that referenced this pull request Apr 26, 2024
…mponents (WordPress#61090)

Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants