-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint-staged-typecheck: don't run TSC when no TS project is affected #60998
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks better, thanks!
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
The
lint-staged-typecheck
script that's run in a precommit hook determines a set of changed packages and runstsc
on a list of the changed package directories.However, when the list of changed packages is empty, because there's no
tsconfig.json
in any affected directory, it runs a redundanttsc --build
command which typechecks the entire project.This PR fixes that so no
tsc --build
is run.How to test: Modify a file in
packages/edit-site
(which doesn't have atsconfig.json
and try to commit.lint-staged-typecheck
task running for quite some time.