CustomSelectControlV2: Support disabled in item types #60896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
force-pushed
the
add/custom-select-control-disabled-type
branch
from
cc6dbc7
to
9d821f1
Compare
mirka
approved these changes
Apr 19, 2024
Co-authored-by: Lena Morita <lena@jaguchi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds support for
disableditems inCustomSelectControlV2types.Why?
CustomSelectControlV2currently supports setting items to be disabled since Ariakit supports it too. However, the item types don't reflect that.Related: #55023
How?
We're adding
disabledas an expected prop by theCustomSelectControlV2.Itemtypes.Testing Instructions
Add a
disabledto one of the items in theCustomSelectControlV2storybook and verify it doesn't trigger a TS error.Testing Instructions for Keyboard
None
Screenshots or screencast
None