Directory

adds: div tag on 'latest posts' block's frontend to match with editor markup by AkmElias · Pull Request #60545 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds: div tag on 'latest posts' block's frontend to match with editor markup #60545

Conversation

AkmElias
Copy link

@AkmElias AkmElias commented Apr 7, 2024

What?

Make consistent Markup in the Editor vs front-end for Latest Posts block.

Why?

There was inconsistent markup in the editor vs. front-end on the 'Latest Posts' block.

Reference: #60540

How?

Add an extra 'div' tag on the frontend to keep consistency in markup in both the frontend and editor and resolving styling issues caused by the inconsistency.

Testing Instructions

  • Go to the editor and create a new post or page.
  • Add the "Latest Posts" block.
  • Save.
  • Inspect the markup rendered in the editor vs. on the front-end.
  • Markup will be in same pattern which was not, previously in frontend there was no 'div' which caused styling issues

Testing Instructions for Keyboard

Screenshots or screencast

@AkmElias AkmElias requested a review from ajitbohra as a code owner April 7, 2024 17:06
Copy link

github-actions bot commented Apr 7, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Block] Latest Posts, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Apr 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: AkmElias <akmelias@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AkmElias! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] Latest Posts Affects the Latest Posts Block label Apr 12, 2024
@carolinan
Copy link
Contributor

Hi @AkmElias Thank you for working on this pull request. The issue was solved by removing the <div> from the editor instead because it was not needed anymore, see: #60728. The markup in the editor and front matches, so I am closing this pull request as solved.

@carolinan carolinan closed this Apr 23, 2024
@AkmElias
Copy link
Author

I also thought removing the

tag from the editor was the solution. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Posts Affects the Latest Posts Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants