Directory

Uses the proper function to output interactivity context by bacoords · Pull Request #60013 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses the proper function to output interactivity context #60013

Closed
wants to merge 1 commit into from

Conversation

bacoords
Copy link
Contributor

What?

In the current Interactivity API create block scaffold, the block's context is output manually in the attribute, but a better example of the best practice would be using wp_interactivity_data_wp_context( $my_context ); per the API Reference

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: bacoords <bacoords@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Create Block /packages/create-block labels Mar 20, 2024
@Mamaduka Mamaduka requested a review from DAreRodz March 20, 2024 03:50
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DAreRodz
Copy link
Contributor

I see this was already solved in #59995, so no changes are needed.

Thanks for the PR anyway, @bacoords! 🙏

@DAreRodz DAreRodz closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Create Block /packages/create-block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants