Fix Navigation block e2e focus test by avoiding reliance on invalid locator #59957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Given that this test caused e2e test failures on the |
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
getdave
added
the
Backport to WP Beta/RC
|
I cherry picked this PR directly into the |
getdave
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the e2e tests for the Nav block which are flaky because they rely on invalid locator.
Why?
We should avoid
getByTestIdbecause it isn't present in certain environments.How?
Removes line. It's not needed to verify the focus behaviour accordingly to @jeryj who is the author.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast