feat: Enable setting HTML anchor IDs for all supported block types #59802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
Mobile App - i.e. Android or iOS
|
Size Change: -49 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
dcalhoun
added
the
Mobile App - Automation
dcalhoun
changed the title
Allow blocks displaying "advanced" controls within a separate inspector section.
Expand anchor support to include all blocks, not just the Heading block.
Swap the Image block for the Shortcode block for the subject of a block with no settings now that anchor support is present for an empty Image block.
dcalhoun
force-pushed
the
feat/enable-block-anchor-support
branch
from
f6a206e
to
c34e3bb
Compare
There is no reason to retain this unused code in the native-specific file.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @iamthomasbishop, @jbinda. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jhnstn
approved these changes
Mar 14, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ordPress#59802) * feat: Support inspector advanced controls Allow blocks displaying "advanced" controls within a separate inspector section. * feat: Enable block anchor support Expand anchor support to include all blocks, not just the Heading block. * docs: Add change log entry * test: Fix hidden block setting button Swap the Image block for the Shortcode block for the subject of a block with no settings now that anchor support is present for an empty Image block. * test: Assert setting anchor HTML ID * refactor: Remove web-specific properties There is no reason to retain this unused code in the native-specific file. Unlinked contributors: iamthomasbishop, jbinda. Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: jhnstn <jsnjohnston@git.wordpress.org> Co-authored-by: derekblank <derekblank@git.wordpress.org> Co-authored-by: pinarol <wppinar@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enable the ability to set an anchor for any block, not just Heading blocks.
Why?
Fixes #28363. Improve web and native mobile editor feature alignment by removing temporary scoping of anchor ID support to Heading blocks.
Fixes wordpress-mobile/gutenberg-mobile#1385. Although, we are unable to simplify the conditional display of the block settings button referenced in the quote above, as there are, in fact, blocks without Advanced Settings like additional CSS class names — e.g., Shortcode. There would need to be an ever-present UI for every block setting before we could remove the conditional block settings button display.
How?
Add a bottom sheet slot for displaying advanced settings beneath a separate section. Refactor the existing anchor hook, removing mobile-specific limiting anchor support to Heading blocks only.
Testing Instructions
The following should be performed for both the web and native mobile editor.
block.jsonattribute.attribute.
Testing Instructions for Keyboard
Perform the aforementioned testing instructions using a screen reader.
Screenshots or screencast
N/A, no visual changes.