Directory

Docs: Flex - Fix headline hierarchy by Soean · Pull Request #59686 · WordPress/gutenberg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Flex - Fix headline hierarchy #59686

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Docs: Flex - Fix headline hierarchy #59686

merged 1 commit into from
Mar 9, 2024

Conversation

Soean
Copy link
Member

@Soean Soean commented Mar 7, 2024

What?

Improves the docs of the Flex component. Two headline have a wrong hierarchy. They should have a h3 intead of a h5.

Live Link | Preview

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@Soean Soean requested a review from ajitbohra as a code owner March 7, 2024 14:52
Copy link

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Soean <soean@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Mar 7, 2024
@t-hamano t-hamano self-requested a review March 9, 2024 08:31
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Since this is a minor modification to the documentation, I think it is okay to not update CHANGELOG in the component package.

@t-hamano t-hamano added the [Package] Components /packages/components label Mar 9, 2024
@t-hamano t-hamano merged commit 427cfa2 into trunk Mar 9, 2024
63 of 65 checks passed
@t-hamano t-hamano deleted the flex-fix-docs branch March 9, 2024 08:35
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants