-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: UBE hides post title input #59324
Conversation
The class addition is a deprecated class that is present when using older versions of the Gutenberg plugin.
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I followed the testing steps, using a self-hosted site without the Gutenberg plugin enabled, and confirmed both platforms work as expected. 🎉 Thanks @dcalhoun! 🙌
What?
Hide the post title input when the editor is displayed for the context of the
unsupported block editor (UBE) for sites running older versions of Gutenberg
— e.g., the block editor in WordPress core rather than a plugin.
Why?
The post title is distracting when editing a single block. The erroneous
visibility of the post title field currently only occurs for older versions of
the Gutenberg plugin.
How?
Apply the hidden styles to the legacy post title class name that is present for
older plugin versions.
gutenberg/packages/editor/src/components/editor-canvas/index.js
Lines 363 to 365 in 0b8c3ad
Testing Instructions
Tip
Use a prototype build: iOS or Android.
Testing Instructions for Keyboard
N/A, no changes to keyboard flow.
Screenshots or screencast