Block Hooks: Fix toggle with Navigation block #59277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the current block
tjcafferkey
added
[Feature] Block hooks
[Type] Bug
|
Size Change: +89 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in af03c88. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8006674137
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pkuliga. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
16 tasks
ockham
added
Backport to WP Beta/RC
ockham
reviewed
Feb 26, 2024
There was a problem hiding this comment.
I realize it was me who originally suggested adding a special case for the Navigation block 🙈 but after some testing, it looks as if we can always use getBlocks() instead 😅
(I've tried inserting hooked blocks after Post Content and as Comment Template's lastChild, and getBlocks returned the relevant candidate blocks as desired in all cases.)
|
Closing in favor of #59367 🙂 |
ockham
removed
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59001
What?
Update the block hooks toggle to use the getBlocks selector to return controlled innerBlocks, which the getBlock selector does not return.
Why?
The getBlock selector doesn't return controller innerBlocks, only uncontrolled. This means when toggling the block hooks toggle on/off it was multiplying the hooked block.
How?
This correctly returns the innerBlocks for the Navigation block. At the moment we have limited this change to only the Navigation block.
Testing Instructions
core/loginoutblocksblock.jsonfile.firstChild,beforeandafterand retest the above steps for each position.Testing Instructions for Keyboard
Screenshots or screencast