-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflows to use gradle/actions/setup-gradle (#58628) #58713
Update workflows to use gradle/actions/setup-gradle (#58628) #58713
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @shreyash3087. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNCore Committers: Use this line as a base for the props when committing in SVN:
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@t-hamano I noticed that the previous pull request (#58645) on the issue (#58628) didn't provide much detail about the changes being made, so I went ahead and created a new pull request (#58713) with the same changes but with additional documentation and clarity. Even though it was a small change,I believe it's important for contributors to have clear information about the purpose and impact of the changes, so I've included detailed explanations in my pull request description. If there are any questions or suggestions, please do let me know. |
Thanks for the PR! As you say, explaining the what, why, and how in PR is extremely important. However, since I am not familiar with Gutenberg mobile, I will add the mobile team as a reviewer 🙇 |
@@ -47,7 +47,7 @@ jobs: | |||
run: npm run native test:e2e:setup | |||
|
|||
- name: Gradle cache | |||
uses: gradle/gradle-build-action@3b1b3b9a2104c2b47fbae53f3938079c00c9bb87 # v3.0.0 | |||
uses: gradle/actions/setup-gradle@3b1b3b9a2104c2b47fbae53f3938079c00c9bb87 # v3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently failing due to the commit hash I believe 🤔 since it references the gradle/gradle-build-action
repo.
I think we should change it to ec92e829475ac0c2315ea8f9eced72db85bb337a which is the v3.0.0
release in the gradle/actions
repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
I checked the the latest run of React Native E2E Tests (Android) and confirmed it worked as expected.
Thanks @shreyash3087 for updating this 🙇 .
@shreyash3087 before proceeding to merge the PR, let us know if you took a look at this comment related to ensuring your work is properly credited in WordPress releases, and in case you'd like first to link your GitHub and WordPress.org account. |
@fluiddot Yes i did read that comment.If we talk about linking my github account to wordpress.org,i did try to do that,i followed the link to login to WordPress.org, but it said that it was an unknown email address.I then tried to go ahead and register my account,but then it said "That username is already in use.Your account is pending approval. You will receive an email at Shreyash3087@gmail.com to set your password when approved." It has now been 3 days since i have been trying to link my accounts,but i have not yet received any approval on my mail. Now coming to the credits part i read the Contribution Attribution Page about credits,but since i am beginner in open-source,its just my second contribution and im learning the stuff, i was confused where to put these credits.It says to put it at the bottom of the merge commit message,so is it talking about the description of the commit message? I was also unsure when do i need to put these credits,after approval or before.I just didn't want to mess anything up ,so i ignored the message. |
Sad to hear you had trouble logging in/registering the account. I'd recommend reaching support at https://wordpress.org/support/forums/.
No worries. The credits will be incorporated in the merge commit once we merge the PR, no need to change anything from your side. The only thing to consider is whether you'd like first to link your WordPress.org account to reference it in the merge commit message or just your GitHub account. |
@fluiddot Thank you for the clarification.I Understand Now. Since I am unsure how long is it gonna take for my Wordpress.org login issue to get resolved,and i can't link my github to WordPress.org without logging in,so I would prefer to have the credits for my contributions solely on GitHub. |
Great, I've just gone ahead and merged the PR. Thanks @shreyash3087 for your contribution 🎊 . |
What?
Updates workflows to use gradle/actions/setup-gradle instead of gradle/gradle-build-action as the latter action has been superseded in version 3.0.0.
fixes #58628
Why?
The
gradle/gradle-build-action
has been updated to version 3.0.0, where it now acts as a pass-through to the preferredgradle/actions/setup-gradle
action. This change ensures that our workflows stay up-to-date with the latest recommended practices and dependencies.How?
The PR modifies the relevant workflows (rnmobile-android-runner.yml) to replace the usage of
gradle/gradle-build-action
withgradle/actions/setup-gradle
.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A