Tabs: delay activeId updates until focus can be properly detected
#58625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make sure the
Tabscomponent doesn't update its internalactiveIdtoo early.Why?
Tabs uses Ariakit internally, which uses an
activeIdproperty to track focus internally. In certain situations, it's possible for that internal focus to become out of sync with actual browser focus, so we update it accordingly to ensure arrow key behavior works as expected.In some cases, such as #56959, the browser focus value doesn't update quickly enough, and our internal syncing efforts lead to arrow keys not working at all, which is obviously not the desired outcome. This PR addresses such cases by delaying the update.
How?
Wrapping our existing logic in
requestAnimationFrame()allows enough time to make sure the currently focused ID has finished updating before we check for a mismatch and update our internal focus value.Testing Instructions
Tabsin site-editor settings #56959, as that PR demonstrates the issue we're solving the most clearly.