(preferences)(17.5.1)(fix) Fix preferences migration 17.5-specific deprecation test failures #58099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… migrated to the `core` scope, but will still work due to the 17.5.1-specific hotfix 17.5.1-specific hotfix: #58031.
fullofcaffeine
added
[Type] Task
|
Closed due to a weird GH bug - when you change the base branch, GH won't trigger all the necessary actions for some reason. I had mistakenly chosen See the new one here: #58100. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why / How?
17.5-specific Follow-up to: #58031. That changeset was a time-sensitive hotfix for 17.5 with benign test failures, AFAICS. This PR aims to fix those tests in the 17.5 branches so that if any other PR is cherry-picked for a future patch release, people will not get confused by the failures.
It's important to note that once 17.6 is released, this will not be too relevant anymore, but will be a good way to document the changes in #58031.
The changes in #58031 make the
getproxy more resilient by falling back to the passed scope to get the preference if it's not found in thecorescope (where the preferences in thesettingsToMoveToCorewere migrated to between 17.5 andtrunk. Some changesets were not included in therelease/17.5branch, causing thegetcall for them to returnundefinedto the consumers and causing unexpected fatal bugs (BSODs/WSODs).On
trunknor this PR nor #58031 are needed because the it should be in a state that #58016 expects -- all of the preferences listed insettingsToMoveToCorehave indeed been moved over to thecorescope.Testing Instructions
All tests should pass.