-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DependencyExtractionWebpackPlugin: Drop webpack4 and node<18 #57303
Conversation
Webpack 5 was released ~3 years ago. New features are being developed around ECMAScript modules, which are unsupported in webpack 4.
v18 is the current LTS release of Node. Older versions are not supported.
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
The lock file needs a refresh: https://github.com/WordPress/gutenberg/actions/runs/7287680671/job/19858795322?pr=57303. Thank you so much for taking care of this legacy support for webpack 4. We don't need it anymore. I think we removed other webpack 4 specific plugin long time ago. |
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Flaky tests detected in 75d793b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7287855004
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good from my perspective.
There are two CI failures on newly added options jobs running Node 21. It might be some caching related issue. Let me know if you can't make them pass and need help force merging this PR.
The dev note doesn't have to be a full-blown post, it could be part of a collection of dev notes. It definitely would need to elaborate on the 'Breaking change'. |
Hi @bph. It may not be clear, but this isn't going to impact the WordPress experience in any way. The affected packages may be used by developers building for WordPress. The packages are consumed via npm. A dev note blurb (I agree a complete post is not necessary) would read something like the following:
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
What?
Dependency Extraction Webpack Plugin:
Scripts:
(dropping from the webpack plugin implies dropping support from scripts)
Why?
Webpack 5 was released more that 3 years ago. Webpack 4 does not support modules, which blocks work on better module support and the modules API.
Node 18 is the oldest maintained Node.js release. Drop support for older versions.
Testing
CI tests should be sufficient for this change. I suggest reviewing changes without whitespace to see that very little code is changed.