Size Change: +34 B (0%)

Total Size: 1.69 MB

_{compressed-size-action}

Flaky tests detected in ac33698.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7280931751
📝 Reported issues:

• [Flaky Test] should be disabled when post is being saved #35641 in /test/e2e/specs/editor/various/publish-button.spec.js

One slightly different behavior that I noticed: on trunk, pressing Tab while focusing a tab moves focus to the tabpanel, while on this PR focus moves directly to the first focusable element in the tabpanel.

This observation threw me a bit, because I'd specifically tried to emulate the existing behavior so I played around with it a bit and I think I understand what's happening (though not entirely why, but that's a question for another day/PR)

If you launch the site editor, and immediately open the Global Styles sidebar, followed by the Style Book, Tab will move you to the first/current tab, and then to the first focusable item within the displayed tabpanel.

However, if you mess around in the editor and focus a block before opening Global Styles & Style Book, the focus behavior changes. Tab still starts by landing on the currently selected tab, but then cycles through various other elements instead of moving directly into the tabpanel.

While this feels off, and I'm not sure what causes it, the behavior seems consistent between trunk and this PR. I don't see any mention of the this tab > tabpanel focus switching in the PR where Style Book was implemented, so I'm going to proceed with the merge 👍