Styles: More descriptive text for revisions timeline #55868
Conversation
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sacerro! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
cbravobernal
added
Global Styles
| @@ -95,7 +95,7 @@ function ScreenRevisions() { | |||
| <ScreenHeader | |||
| title={ __( 'Revisions' ) } | |||
| description={ __( | |||
| 'Revisions are added to the timeline when style changes are saved.' | |||
| 'Restore styles from an earlier version of changes that was automatically added to this timeline when new styles were saved.' | |||
There was a problem hiding this comment.
Thanks for the PR!
The three clauses make it a bit of a mouthful in my opinion.
If we're seeking both clarity and guidance as mentioned in the issue, maybe we could:
- describe what the user is looking at (the clarity)
- provide instruction on how to restore styles (the guidance).
Not being prescriptive, these are just ideas. Language is fuzzy 😄
E.g.,
This is pretty verbose:
Click on previously saved styles to preview them. To restore a selected version to the editor, hit "Apply". When you're ready, save the template to commit your changes.
A bit more condensed:
A timeline of saved changes to your site's styles. Click "Apply" to restore a selected version in the editor.
What do you reckon?
As a heads up, the revisions panel will be getting a UX makeover soon: #55776
There was a problem hiding this comment.
I think the verbose option is the best. It explains better to the user what this panel do.
What do you think @pablohoneyhoney?
There was a problem hiding this comment.
I replace the text by the one you suggested 💪
There was a problem hiding this comment.
@sacerro wording looks good on the longer option, but the period needs to go inside the quotation mark like so:
Click on previously saved styles to preview them. To restore a selected version to the editor, hit "Apply." When you're ready, save the template to commit your changes.
There was a problem hiding this comment.
Thanks @provenself
I've updated the copy to reflect the latest changes.
I'll merge this PR.
Thanks also to @sacerro !
ramonjd
added
the
Needs Copy Review
packages/edit-site/src/components/global-styles/screen-revisions/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
packages/edit-site/src/components/global-styles/screen-revisions/index.js
Outdated
Show resolved
Hide resolved
|
Sorry, I'd set this to auto merge, but I think forgot to approve 🤦🏻 Thanks for your patience! |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
What?
Fixes #55648. Made in WordCamp Madrid 2023
Why?
Current text needs more context. Proposed text fits better.
How?
Replaced old text by new one proposed.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast