Block Theme Preview: Display the theme name on the activate button #55752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthur791004
force-pushed
the
feat/add-previewing-theme-to-activate-button
branch
from
20233de
to
53d02da
Compare
okmttdhr
approved these changes
Nov 6, 2023
okmttdhr
reviewed
Nov 6, 2023
| isDirty: dirtyEntityRecords.length > 0, | ||
| isSaving: | ||
| dirtyEntityRecords.some( ( record ) => | ||
| isSavingEntityRecord( record.kind, record.name, record.key ) |
There was a problem hiding this comment.
There seems to be a prettier error on this line.
https://github.com/WordPress/gutenberg/actions/runs/6730275641/job/18292658610?pr=55752#step:5:592
Replace `·record.kind,·record.name,·record.key·` with `⏎↹↹↹↹↹↹↹record.kind,⏎↹↹↹↹↹↹↹record.name,⏎↹↹↹↹↹↹↹record.key⏎↹↹↹↹↹↹` prettier/prettier
I don't think this has anything to do with this PR change, but it would be good to address it before merging! @arthur791004
I'm sorry for my late review.
arthur791004
force-pushed
the
feat/add-previewing-theme-to-activate-button
branch
from
6e32c7e
to
0f46f65
Compare
scruffian
approved these changes
Nov 16, 2023
arthur791004
deleted the
feat/add-previewing-theme-to-activate-button
branch
mcsf
reviewed
Dec 15, 2023
Comment on lines
+63
to
+69
| return sprintf( 'Activating %s', previewingThemeName ); | ||
| } else if ( disabled ) { | ||
| return __( 'Saved' ); | ||
| } else if ( isDirty ) { | ||
| return __( 'Activate & Save' ); | ||
| return sprintf( 'Activate %s & Save', previewingThemeName ); | ||
| } | ||
| return __( 'Activate' ); | ||
| return sprintf( 'Activate %s', previewingThemeName ); |
There was a problem hiding this comment.
With this PR, these strings are no longer translated. This needs to be fixed, @arthur791004.
Since the new strings involve interpolation, they require // translators: notes.
There was a problem hiding this comment.
Here is the fix: #57147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We want to display the name of the previewing theme on the “Activate” button to make it clearer what theme you're previewing.
Note that I keep the text of the “Activate” button on both “Save modal” and “Save panel” unchanged as
Does it make sense? Or do we still want to display the theme name there?
Why?
Resolve #52772
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast