Fix missing data in email submissions #55691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +19 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Nov 2, 2023
email forms have |
draganescu
reviewed
Nov 13, 2023
| @@ -20,6 +20,8 @@ document.querySelectorAll( 'form.wp-block-form' ).forEach( function ( form ) { | |||
| formData.formAction = form.action; | |||
| formData._ajax_nonce = wpBlockFormSettings.nonce; | |||
| formData.action = wpBlockFormSettings.action; | |||
| formData._wp_http_referer = window.location.href; | |||
There was a problem hiding this comment.
Overriding _wp_http_referer like this makes me anxious. Why is this needed?
There was a problem hiding this comment.
The data is not actually sent with the AJAX request... so we're just adding it here.
| @@ -109,7 +109,7 @@ function block_core_form_send_email() { | |||
|
|
|||
| // Send the email. | |||
| $result = wp_mail( | |||
| str_replace( 'mailto:', '', $params['wp-email-address'] ), | |||
| str_replace( 'mailto:', '', $params['formAction'] ), | |||
There was a problem hiding this comment.
This seems like the main bug fixed here, right?
| @@ -96,7 +96,7 @@ function block_core_form_send_email() { | |||
| '<a href="' . esc_url( get_site_url( null, $params['_wp_http_referer'] ) ) . '">' . get_bloginfo( 'name' ) . '</a>' | |||
| ); | |||
|
|
|||
| $skip_fields = array( 'formAction', '_ajax_nonce', 'action' ); | |||
| $skip_fields = array( 'formAction', '_ajax_nonce', 'action', '_wp_http_referer' ); | |||
There was a problem hiding this comment.
Maybe too late but it'd be great if we could instead of keeping alist of fields to skip, find a way to identify what to include - like if we had a prefix for all fields that should be emailed or something?
There was a problem hiding this comment.
Well, the args that need to be ignored are finite and known... That's why I thought it best to keep it clean and not add prefixes to the other ones. 😃
There was a problem hiding this comment.
the args that need to be ignored are finite and known
Today! But one day some hidden thing _don't_email_me will show up and be emailed :)
aristath
force-pushed
the
fix-form-submittions-email-data
branch
from
c566fbe
to
5caf443
Compare
|
I am looking forward to getting this one merged. As I will then be able to test out the Forms block. |
draganescu
approved these changes
Jan 30, 2024
aristath
force-pushed
the
fix-form-submittions-email-data
branch
from
5caf443
to
81784dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue with form submissions from the experimental form block, when using the email method.
Why?
Because emails were not being sent when submitting a form
How?
Adds missing data to the script, which then lets the form submission email to be properly sent.
Testing Instructions
type="submit"for buttons #55690. If that PR doesn't get merged before this one, then you'll need to manually change the type of the button tosubmitfrom your browser's tools, so the form can be properly submitted)Testing Instructions for Keyboard
Not applicable