Size Change: -98 B (0%)

Total Size: 1.42 MB

_{compressed-size-action}

Thanks for the PR!

I think this side effect was introduced in #36125 to apply a default style (No label, icon button, inside button) when a search block is inserted into a navigation block. Therefore, simply removing this side effect would cause regression regarding #31127, which was resolved in the past.

I think the fundamental problem is that when we change the attributes of a search block that has already been inserted, an unintended side effect is executed. I think it would be better to adjust the intended behavior without removing this side effect.

This PR

Trunk

I see what you mean, I will try fixing the intended behavior of this side effect instead of removing it.

After more investigation, it looks like wasBlockJustInserted is not working reliably, causing the attributes to be reset every re-render.

I didn't work out how to solve this yet, but I did find something we can simplify: #52519

I think we can fix this with #52558

Closing in favor of #52558.