Change resource URL in source map for @wordpress packages. #51401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
[Type] Enhancement
|
Size Change: -2.13 kB (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4baf491. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6124637212
|
torounit
added
[Type] Build Tooling
|
@gziolo Could you review this PR? |
|
Hello, I don't have much experience configuring source maps with webpack. I landed 4 years ago PR #17024 that set a constant namespace with |
torounit
force-pushed
the
add/sorce-map-path
branch
from
ff2df57
to
6fa1f82
Compare
screenshot of chrome.
screenshot of firefox.
screenshot of safari
firefox and chome will jump to the original source code. |
t-hamano
reviewed
Sep 8, 2023
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
As long as it's about the source map generated by the plugin and not by the packages, it's good to go (since it has been tested). I wonder if a similar change is needed on Core. |
|
@youknowriad |
noahtallen
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
I confirmed the sourcemaps for packages are the same (which makes sense, since those aren't generated by webpack). Looking at the sourcemaps for @wordpress/annotations (under build/annotations):
before:
"sources": [
"webpack://wp/webpack/bootstrap",
"webpack://wp/webpack/runtime/define property getters",
"webpack://wp/webpack/runtime/hasOwnProperty shorthand",
"webpack://wp/webpack/runtime/make namespace object",
"webpack://wp/external window [\"wp\",\"richText\"]",
"webpack://wp/external window [\"wp\",\"i18n\"]",
"webpack://wp/./packages/annotations/build-module/store/@wordpress/annotations/src/store/constants.js",
"webpack://wp/./packages/annotations/build-module/format/@wordpress/annotations/src/format/annotation.js",
"webpack://wp/./packages/annotations/build-module/format/@wordpress/annotations/src/format/index.js",
"webpack://wp/external window [\"wp\",\"hooks\"]",
"webpack://wp/external window [\"wp\",\"data\"]",
"webpack://wp/./packages/annotations/build-module/store/@wordpress/annotations/src/store/reducer.js",
"webpack://wp/./packages/annotations/build-module/block/@wordpress/annotations/src/block/index.js",
"webpack://wp/./node_modules/rememo/rememo.js",
"webpack://wp/./packages/annotations/build-module/store/@wordpress/annotations/src/store/selectors.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/rng.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/stringify.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/regex.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/validate.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/v4.js",
"webpack://wp/./packages/annotations/build-module/store/@wordpress/annotations/src/store/actions.js",
"webpack://wp/./packages/annotations/build-module/store/@wordpress/annotations/src/store/index.js"
],after:
"sources": [
"webpack://wp/webpack/bootstrap",
"webpack://wp/webpack/runtime/define property getters",
"webpack://wp/webpack/runtime/hasOwnProperty shorthand",
"webpack://wp/webpack/runtime/make namespace object",
"webpack://wp/external window [\"wp\",\"richText\"]",
"webpack://wp/external window [\"wp\",\"i18n\"]",
"../../packages/annotations/src/store/constants.js",
"../../packages/annotations/src/format/annotation.js",
"../../packages/annotations/src/format/index.js",
"webpack://wp/external window [\"wp\",\"hooks\"]",
"webpack://wp/external window [\"wp\",\"data\"]",
"../../packages/annotations/src/store/reducer.js",
"../../packages/annotations/src/block/index.js",
"webpack://wp/./node_modules/rememo/rememo.js",
"../../packages/annotations/src/store/selectors.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/rng.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/stringify.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/regex.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/validate.js",
"webpack://wp/./packages/annotations/node_modules/uuid/dist/esm-browser/v4.js",
"../../packages/annotations/src/store/actions.js",
"../../packages/annotations/src/store/index.js"
],This makes sense to me 👍
|
I will go ahead and merge it, since @youknowriad said it is good to go. |
noahtallen
pushed a commit
that referenced
this pull request
Oct 6, 2023
…1401) * Change the URL of the packages output in the source map. --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
noahtallen
pushed a commit
that referenced
this pull request
Oct 10, 2023
…1401) * Change the URL of the packages output in the source map. --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change the URL of
@wordpresspackages referenced in the source map. Specifically, the following will be used.before:
webpack://wp/packages/a11y/build-module/@wordpress/a11y/src/index.jsafter:
../../packages/a11y/src/index.jsWhy?
When VS Code and a browser are linked, the actual file can be referenced from the debug console. Also, operations such as breakpoints can be performed from VS Code.
The lanch.json configuration is as follows
How?
Set
devtoolModuleFilenameTemplateScreenshots or screencast
2023-06-11.20.29.53.mov