Update Welcome Guide article links to avoid redirect #48582
Conversation
The link title Here's a detailed guide opens in a new tab to a help article which is a redirected link. We should point directly to the correct article. My PR addresses this small change and points to https://wordpress.org/documentation/article/wordpress-block-editor/.
| @@ -119,7 +119,7 @@ export default function WelcomeGuideStyles() { | |||
| ) } | |||
| <ExternalLink | |||
| href={ __( | |||
| 'https://wordpress.org/support/article/styles-overview/' | |||
| 'https://wordpress.org/documentation/article/wordpress-block-editor/' | |||
There was a problem hiding this comment.
Thanks for working on this.
This doesn't seem to be the right link that has been updated. There are a few welcome guides, this one is for globals styles and has a different URL.
I see it still has a redirect though. The URL now resolves to https://wordpress.org/documentation/article/styles-overview/, so it might still be worth updating it, but also updating the other ones too.
There are a few that I found that have the link you mentioned:
There was a problem hiding this comment.
Thank you for your comment. Yes you are correct, I have edited the wrong link in this case. I will recheck and edit the PR.
There was a problem hiding this comment.
Thanks for working on this.
This doesn't seem to be the right link that has been updated. There are a few welcome guides, this one is for globals styles and has a different URL.
I see it still has a redirect though. The URL now resolves to https://wordpress.org/documentation/article/styles-overview/, so it might still be worth updating it, but also updating the other ones too.
There are a few that I found that have the link you mentioned:
Thank you @talldan. I have adjusted the links for all suggested, as there is no reason to display the redirected url. This now fixes the problem I was originally addressing.
For the initial url which I edited incorrectly, I have reverted this change for now, and will address it in a different PR to avoid confusion.
SavPhill
requested review from
draganescu,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
Reverting this incorrect link edit. This does require changing, but will be addressed in a different PR
SavPhill
requested review from
talldan
and removed request for
draganescu,
adamziel,
noisysocks,
kevin940726 and
tellthemachines
talldan
added
[Type] Task
talldan
changed the title
What?
In the Welcome Guide, the final step titled 'Learn how to use the block editor' links to a support article under 'Here's a detailed guide' which opens a new tab for the url: https://wordpress.org/support/article/wordpress-editor/.
This url has since been redirected, and the final url the user will visit will be: https://wordpress.org/documentation/article/wordpress-block-editor/
Why?
There is no valid reason to point to an old url for this support article. By doing so, it slows the help experience down as the user is redirected but more importantly could lead to a broken page if the redirect is removed in error at a later date.
How?
My PR removes the need for the redirection, by pointing the user directly to the correct help article.
Testing Instructions
Visit the Welcome Guide modal
Follow the Welcome Guide steps until the 4th and final one.
Hover over the link titled Here's a detailed guide and view the url.
Click the link and view the final url in the address bar.
Fixes #48583.
Testing Instructions for Keyboard
Screenshots or screencast